search

application-research / estuary

A custom IPFS/Filecoin node that makes it easy to pin IPFS content and make Filecoin deals.
https://docs.estuary.tech
Other
240 stars 66 forks source link

Estuary can't build on go version 1.19 #403

Open mvjq opened 2 years ago

mvjq commented 2 years ago

Describe the bug Having the go1.19 version, if I try to build the estuary with make clean all an error happens related to the quic-go dependency:

image

works with go1.18 version:

sed -i 's/go build/go1.18 build/g' Makefile
make clean all

To Reproduce Steps to reproduce the behavior:

  1. Upgrade go to version 1.19
  2. run make clean all

Expected behavior Build the estuary artifacts

Actual behavior Can not build

Solutions Proposal

  1. Upgrade the docs to reflect this incompatibility (go 1.15 >= and <= go 1.18)
  2. Upgrade the quic-go to the latest version and check compatibility

which solution do you guys prefer?

alvin-reyes commented 2 years ago

Using the appropriate labels for this. This is not a bug but rather an improvement to the code base.