application-research / fevm-nft-estuary

ERC721 contract that uses Estuary for storing digital asset metadata
3 stars 1 forks source link

Can't compile Diesel contract #2

Open Kevin-Mok opened 1 year ago

Kevin-Mok commented 1 year ago

When running truffle compile, I'm getting a couple of errors. First is:

CompileError: ParserError: Expected pragma, import directive or contract/interface/library/struct/enum/constant/function definition.
  --> project:/contracts/DieselPriceOracleCall.sol:37:2:
   |
37 | }a
   |  ^

I opened a PR for this (#3). After fixing that, I'm getting:

CompileError: ParserError: Source "https://github.com/provable-things/ethereum-api/blob/master/contracts/solc-v0.8.x/provableAPI.sol" 
not found --> project:/contracts/DieselPriceOracleCall.sol:3:1:
  |
3 | import "https://github.com/provable-things/ethereum-api/blob/master/contracts/solc-v0.8.x/provableAPI.sol";
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Which is weird since it does exist, and the Remix docs say that's how you should import from GitHub.

alvin-reyes commented 1 year ago

This is not meant to work yet. FEVM seems to lack support for it. I also commented it out.

I prepared oracle contracts (i also have one oracle for fil/usdt pricing) once it completely supports it.

I’ll write a separate repo for oracles once I can confirm that its working.