search

applicationsonline / librarian-chef

Librarian-Chef - A Bundler for your Chef Cookbooks. Librarian is at: https://github.com/applicationsonline/librarian.
http://applicationsonline.com/
MIT License
360 stars 55 forks source link

Replace possibly buggy FileUtils.mv with a two step solution #30

Open emyl opened 10 years ago

emyl commented 10 years ago

On Windows 7/8 64bit, when using librarian-chef both standalone and trough vagrant, the FileUtils.mv operation fails with Errno::EACCES (permission denied). I suspect it could be a ruby bug, in any case it could be easily worked around.

Zaylril commented 10 years ago

I also get this bug on both standalone and vagrant plugin. Would be nice to see it merged in and fixed.

emyl commented 10 years ago

@Zaylril in case you're interested, The following forks include the bug fix:

https://github.com/emyl/librarian-chef-nochef https://github.com/emyl/vagrant-librarian-chef-nochef

yfeldblum commented 10 years ago

I want atomic rename. I don't want partially-copied directories.

It looks like there is a bug with this description in some versions of Ruby: https://bugs.ruby-lang.org/issues/8109. Is this what you're running into?

emyl commented 10 years ago

Not really. After investigating a little bit more, I think that the issue could be caused by the virus scanner:

https://www.ruby-forum.com/topic/1044813 https://tickets.puppetlabs.com/browse/PUP-1918