applicationsonline / librarian

Librarian - A Framework for Bundlers. Librarian-Chef is at: https://github.com/applicationsonline/librarian-chef.
http://applicationsonline.com/
MIT License
654 stars 71 forks source link

make knife integration install path match locally configured one #118

Open erkki opened 11 years ago

erkki commented 11 years ago

When using the knife integration,

  require 'librarian/chef/integration/knife'
  cookbook_path Librarian::Chef.install_path, 'site-cookbooks'

the install path should be at least configurable to match up with what's used in-repository (ie the default cookbooks, relative to project dir). Otherwise what's visible (and git-ignored) inside the repository/cookbooks may get out of sync with what's under knife integration install_path.

Furthermore, this breaks unqualified "knife cookbook create" as the created cookbook would be created under the temporary install_path which would get removed right after the command.

Could anyone clarify the rationale behind choosing a differing install_path for knife integration to begin with?