Closed bradleyd closed 11 years ago
A couple points:
etc
is part of the stdlib. I don't think there needs to be a gemspec dependency on it.ENV
in the test. See Support::WithEnvMacro#with_env
for running code in a block with the altered environment, and restoring the environment after the block.default_home
rather than set_home
.Dir.home
is not present on ruby-1.8.7. Librarian must be compatible with ruby-1.8.7 for the time being. In addition, in ruby-1.9.3, Dir.home
called with no arguments will return the homedir of the current or logged-in user, so you don't need Etc
for that. However, you can use Etc.getpwnam
like so: Etc.getpwnam(Etc.getlogin).dir
.Cool, thanks for the points! I will make those changes.
a fix for
not being set