applicationsonline / librarian

Librarian - A Framework for Bundlers. Librarian-Chef is at: https://github.com/applicationsonline/librarian-chef.
http://applicationsonline.com/
MIT License
655 stars 71 forks source link

Support multiple version strategies for Librarian::Manifest #152

Closed justenwalker closed 2 years ago

justenwalker commented 11 years ago

Summary

As mentioned in PR #150 by @yfeldblum. Lack of Semver 2.0.0 support exposes the need to support multiple version strategies.

This PR attempts to add multi-version support to Manifests (defaulting to GemVersion) and offers SemanticVersion as a built-in strategy that downstream projects can use on by overriding Librarian::Environment

def adapter_manifest_version
  Librarian::ManifestVersion::SemanticVersion
end

Changes

justenwalker commented 10 years ago

any thoughts on this @yfeldblum?

patcon commented 10 years ago

bump?

justenwalker commented 10 years ago

@yfeldblum is there anything you need me to do to make this patch acceptable for merge?

krobertson commented 10 years ago

Bump... would love this functionality as well, since getting bit by using librarian for something that doesn't confirm to ruby's version format.