search

applicationsonline / librarian

Librarian - A Framework for Bundlers. Librarian-Chef is at: https://github.com/applicationsonline/librarian-chef.
http://applicationsonline.com/
MIT License
655 stars 71 forks source link

Git cache key without path included #154

Closed bcatlin closed 10 years ago

bcatlin commented 11 years ago

I have a git repo with many paths which was getting cached many times with librarian. This fixes that by removing the path from the cache key.

patcon commented 10 years ago

Whoop! So glad to see someone else was hitting this :)

For those using the travis cookbooks directory (which is huge), this was a concern.

Also, currently trying to move the drupal.org infra repo to librarian-puppet, and that repo is massive, so it definitely nixes that specific implementation.

One suggestion (and yes, it's contentious and I'm not sure it's a good idea), could use git clone --reference to make one official clone, and then make each specific cache (possibly with different vcs references) using using the --reference flag. Of course, there is at least one caveat :)

With --reference, it might help the cache key be a function of just the remote url, and not remote+reference

yfeldblum commented 10 years ago

Closed by f47d61d9d321a040d4c24eeb0bf1676c8526b21f. Thanks for your change!