Fix JRuby exception in posix run! method

applicationsonline / librarian

Librarian - A Framework for Bundlers. Librarian-Chef is at: https://github.com/applicationsonline/librarian-chef.

http://applicationsonline.com/

MIT License

655 stars 71 forks source link

Closed justenwalker closed 10 years ago

justenwalker commented 10 years ago

NoMethodError:
undefined method `success?' for #<Process::WaitThread:0xd5c0e84 dead>

WaitThread does not have a success? method, but it does have a value property which can be checked instead.

Build succeeds with jruby-d19

yfeldblum commented 10 years ago

Process.waitpid docs say that Process.waitpid sets $? to an instance of Process::Status.

RubySpec is unfortunately blank.

Is this a bug in JRuby?

justenwalker commented 10 years ago

Other comments I found suggest IO.popen3 returns a thread. It could be a bug though, I don't know enough about jruby to confirm.

Update: Sorry, I mean to say IO.popen3 sets $? to WaitThread not returns

yfeldblum commented 10 years ago

Completely misread things. D'oh.

yfeldblum commented 10 years ago

This should probably be using Open3.capture3 anyway....