applicationsonline / librarian

Librarian - A Framework for Bundlers. Librarian-Chef is at: https://github.com/applicationsonline/librarian-chef.
http://applicationsonline.com/
MIT License
655 stars 71 forks source link

Assist with librarian-chef issue #57 #181

Open tenaciousRas opened 7 years ago

tenaciousRas commented 7 years ago

I filed issue #57 in librarian-chef at https://github.com/applicationsonline/librarian-chef/issues/57. Upon further inspection it looks like this might be an issue with librarian. Other librarian plugins such as librarian-puppet might exhibit the same issue, although I haven't verified.

Specifically it looks like the method Clean#clean_install_path;21-28 does the nuking (permanently deletes work).

https://github.com/applicationsonline/librarian/blob/b968cd91a3955657bf6ea728b922f2cb74843264/lib/librarian/action/clean.rb

If I'm right then what concerns me is how to patch it in this architecture. How does librarian tell plugins like librarian-chef that a call to clean_install_path either requires librarian-chef to prompt the user or provide an override before potentially nuking the current working directory?

Please advise as to whether the original bug report is filed in the proper project, and/or any suggestions for a patch.