search

applidium / OverlayContainer

Non-intrusive iOS UI library to implement overlay based interfaces
https://gaetanzanella.github.io/2018-12-17/replicating-apple-maps-overlay
Other
1.15k stars 94 forks source link

Missing param in willEndDraggingOverlay delegate call #56

Closed opchronatron closed 4 years ago

opchronatron commented 4 years ago

In an older version, you used to pass the transitionCoordinator. I use this to match animations when the overlay is animating to a notch. Your comments still reference the transitionCoordinator but it is missing in the call function see below.

/// Tells the delegate when the user finishs dragging the overlay view controller with the specified velocity. /// /// - parameter containerViewController: The container requesting this information. /// - parameter overlayViewController: The current top overlay view controller. /// - parameter transitionCoordinator: The transition coordinator object associated with the translation end. func overlayContainerViewController(_ containerViewController: OverlayContainerViewController, willEndDraggingOverlay overlayViewController: UIViewController, atVelocity velocity: CGPoint)

gaetanzanella commented 4 years ago

Hi @opchronatron, thanks for pointing this issue in the comments.

Use willTranslateOverlay instead.

func overlayContainerViewController(_ containerViewController: OverlayContainerViewController,
                                    willTranslateOverlay overlayViewController: UIViewController,
                                    transitionCoordinator: OverlayContainerTransitionCoordinator)