Declare class & methods as `open`

applidium / OverlayContainer

Non-intrusive iOS UI library to implement overlay based interfaces

https://gaetanzanella.github.io/2018-12-17/replicating-apple-maps-overlay

Other

1.15k stars 94 forks source link

Declare class & methods as `open` #61

Closed peterkovacs closed 4 years ago

peterkovacs commented 4 years ago

This change is motivated by wanting to put the top level OverlayContainerViewController inside a navigationViewController. As a standalone class it wasn't setting the navigationItems appropriately.

With these changes I could create a subclass and set it as the delegate which really simplified my usage and class hierarchy.

gaetanzanella commented 4 years ago

Hi @peterkovacs, thanks for the PR! Specially for the weak problem…

You have some CI issues

gaetanzanella commented 4 years ago

3.3.0 released!