search

applitools / Eyes.Sdk.JavaScript

Applitools SDK for Selenium 3. This repository is deprecated. It has moved to https://github.com/applitools/eyes.sdk.javascript1/tree/master/packages/eyes-selenium-3
6 stars 17 forks source link

new tests should pass #46

Closed corevo closed 6 years ago

astappiev commented 6 years ago

This implementation of isPassed is similar to server-side status value. And the value may be Passed only in case if no differences found.

Also, it makes no sense, because in endSession method, we handle new tests in a different way and also depends on configuration new tests may throw errors or not. https://github.com/applitools/Eyes.Sdk.JavaScript/blob/master/src/EyesBase.js#L865

corevo commented 6 years ago

@danielputerman input?
I was under the impression that new tests should be treated as passed, since they are such in the UI.