search

applitools / Eyes.Sdk.JavaScript

Applitools SDK for Selenium 3. This repository is deprecated. It has moved to https://github.com/applitools/eyes.sdk.javascript1/tree/master/packages/eyes-selenium-3
6 stars 17 forks source link

Error: ReferenceError: name is not defined after 0.0.72 release #57

Closed argshook closed 6 years ago

argshook commented 6 years ago

Hello!

Our builds started to fail after 0.0.72 was released

Error: ReferenceError: name is not defined
    at EyesBase.setBatch (/home/builduser/agent00/work/df7e5aad8673267c/node_modules/eyes.sdk/src/EyesBase.js:467:23)
    at _init (/home/builduser/agent00/work/df7e5aad8673267c/node_modules/eyes.it/index.js:124:8)
    at Object.<anonymous> (/home/builduser/agent00/work/df7e5aad8673267c/node_modules/eyes.it/index.js:127:1)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)

please let me know if more details are needed

thank you!

argshook commented 6 years ago

im guessing blindly, but from code it looks like issue is simple typo, here's PR https://github.com/applitools/Eyes.Sdk.JavaScript/pull/58

argshook commented 6 years ago

@danielputerman fyi, sorry for spam :)

danielputerman commented 6 years ago

Lol, no spam at all :) Fix available now in version 0.0.73 (eyes.selenium 0.0.83 works with this version).

argshook commented 6 years ago

Great, thank you!

On Fri, Jul 20, 2018, 17:18 danielputerman notifications@github.com wrote:

Lol, no spam at all :) Fix available now in version 0.0.73 (eyes.selenium 0.0.83 works with this version).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/applitools/Eyes.Sdk.JavaScript/issues/57#issuecomment-406614504, or mute the thread https://github.com/notifications/unsubscribe-auth/AEFg85EwCPPzLUaUNuugEHj8pw1Pfdj7ks5uIeaygaJpZM4VXjct .