applitools / Eyes.Sdk.JavaScript

Applitools SDK for Selenium 3. This repository is deprecated. It has moved to https://github.com/applitools/eyes.sdk.javascript1/tree/master/packages/eyes-selenium-3
6 stars 17 forks source link

Using RequestJS Bails out of async function error handling #78

Open aryelu opened 4 years ago

aryelu commented 4 years ago

Since request lib uses EventEmitter the invocation of error event is taken out of the promises flow https://github.com/request/request/blob/master/request.js#L187. So if an error is thrown in the callback of that error it will result in the function _sendRequest not to be resolved or rejected.

Also see https://github.com/applitools/Eyes.Sdk.JavaScript/pull/77