search

apploft / ExpandableLabel

A simple UILabel subclass that shows a tappable link if the content doesn't fit the specified number of lines
MIT License
463 stars 126 forks source link

Objective C doesn't see label delegate property and protocol definition #67

Open LugonjaAleksandar opened 5 years ago

LugonjaAleksandar commented 5 years ago

There are @objc declarations missing for delegate property and for protocol declaration in the library, and therefore Objective-C doesn't see this property at all and can't be used within Obj-C project. Please include this fix in your next release (add @objc before the delegate property and before protocol). Would be a good idea to create sample project in Objective-C just to be sure everything written is Swift is accessible from objective-c. It might also be a good idea to make all those delegate methods optional, so developers can decide which one is needed, and not include all 4 just to use a single one in the project.

tachtevrenidis commented 5 years ago

@LugonjaAleksandar take a look and let me know

LugonjaAleksandar commented 5 years ago

@tachtevrenidis Yes, that is exactly what was missing. Thanks for this fast fix. :)

tachtevrenidis commented 5 years ago

alright let's see if we can get this merged! @tinora