appmattus / certificatetransparency

Certificate transparency for Android and JVM
Apache License 2.0
142 stars 29 forks source link

Fix reading ASN.1 length field plus more robust tests #84

Closed mattmook closed 1 year ago

mattmook commented 1 year ago

Fixes #80 and #83

codecov[bot] commented 1 year ago

Codecov Report

Merging #84 (c2c8063) into main (f167a3d) will increase coverage by 4.33%. The diff coverage is 83.27%.

@@             Coverage Diff              @@
##               main      #84      +/-   ##
============================================
+ Coverage     71.26%   75.59%   +4.33%     
- Complexity      392      485      +93     
============================================
  Files           110      116       +6     
  Lines          1855     2004     +149     
  Branches        263      313      +50     
============================================
+ Hits           1322     1515     +193     
+ Misses          408      351      -57     
- Partials        125      138      +13     
Impacted Files Coverage Δ
...etransparency/internal/utils/X509CertificateExt.kt 100.00% <ø> (ø)
...catetransparency/internal/utils/asn1/ASN1Logger.kt 0.00% <0.00%> (ø)
...rency/internal/utils/asn1/ASN1PrintableStringUS.kt 0.00% <0.00%> (ø)
...nternal/utils/asn1/x509/CertificateSerialNumber.kt 75.00% <50.00%> (+3.57%) :arrow_up:
...etransparency/internal/utils/asn1/x509/Validity.kt 92.85% <50.00%> (+46.70%) :arrow_up:
...ernal/utils/asn1/header/ASN1HeaderTagExtensions.kt 56.81% <56.81%> (ø)
...al/utils/asn1/header/ASN1HeaderLengthExtensions.kt 75.00% <75.00%> (ø)
...parency/internal/utils/asn1/x509/TbsCertificate.kt 68.75% <76.47%> (+5.59%) :arrow_up:
...arency/internal/utils/asn1/header/ASN1HeaderTag.kt 89.18% <89.18%> (ø)
...atetransparency/internal/utils/asn1/ASN1Integer.kt 92.85% <90.90%> (+21.42%) :arrow_up:
... and 17 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.