search

appmattus / certificatetransparency

Certificate transparency for Android and JVM
Apache License 2.0
146 stars 29 forks source link

Enables Java 8+ API desugaring support #86

Closed viter-sweatcon closed 1 year ago

viter-sweatcon commented 1 year ago

Fixes crash: java.lang.NoClassDefFoundError: Failed resolution of: Ljava/time/Duration; for android devices with api level < 26 by enabling android's D8 API desugaring (https://developer.android.com/studio/write/java8-support#library-desugaring).

viter-sweatcon commented 1 year ago

Looks like it's a fix for https://github.com/appmattus/certificatetransparency/issues/85

viter-sweatcon commented 1 year ago

Or may be it's a bad idea to make this change in library project and It will be better to setup API desugaring of client side (in app module) ...

mattmook commented 1 year ago

Or may be it's a bad idea to make this change in library project and It will be better to setup API desugaring of client side (in app module) ...

Yes my preference would be not update the library for this. This does however highlight I'm not documenting this though so I'll add something to the readme.