appmattus / certificatetransparency

Certificate transparency for Android and JVM
Apache License 2.0
142 stars 29 forks source link

Extract commonName from certificate using ASN.1 #88

Closed mattmook closed 1 year ago

mattmook commented 1 year ago

Also added test to ensure we don't directly call any other non-Android SDKs in the future.

As part of testing I've loaded up certificates from the top 100 or so domain names and everything seems to be pulling back okay.

Fixes #87

codecov[bot] commented 1 year ago

Codecov Report

Merging #88 (634f90b) into main (34eb201) will increase coverage by 0.84%. The diff coverage is 90.90%.

@@             Coverage Diff              @@
##               main      #88      +/-   ##
============================================
+ Coverage     75.29%   76.14%   +0.84%     
- Complexity      482      496      +14     
============================================
  Files           116      116              
  Lines          2004     2012       +8     
  Branches        313      314       +1     
============================================
+ Hits           1509     1532      +23     
+ Misses          354      341      -13     
+ Partials        141      139       -2     
Impacted Files Coverage Δ
...al/verifier/CertificateTransparencyTrustManager.kt 71.73% <66.66%> (+1.28%) :arrow_up:
...atetransparency/internal/utils/PublicKeyFactory.kt 92.85% <100.00%> (+17.85%) :arrow_up:
...ransparency/internal/utils/asn1/query/ASN1Query.kt 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.