search

appneta / tcpreplay

Pcap editing and replay tools for *NIX and Windows - Users please download source from
http://tcpreplay.appneta.com/wiki/installation.html#downloads
1.18k stars 269 forks source link

Update strlcpy.c and strlcat.c #656

Closed guijan closed 3 years ago

guijan commented 3 years ago

The other BSD functions in the /lib directory are outdated too but I'm not familiar with them and I haven't checked if there are any breaking changes to their interfaces.

Additionally, have you considered the libbsd library? It's a popular library so it's on pretty much every distro repo and it runs on Linux, Mac, and it doesn't run on Windows but there Cygwin provides BSD functions instead and Microsoft's WSL is just Ubuntu as far as we're concerned.

The library provides all the BSD extensions in the /lib directory of tcpreplay's source tree and many more, it also has an "overlay" mode that introduces the functions in the same standard headers that the BSDs extend, and if the libc it was compiled for implements the functions it doesn't include them. Cygwin also provides the BSD functions in the standard headers, so portability is only a matter of depending on the library on Linux, WSL, and Mac.

fklassen commented 3 years ago

Thanks for the PRs. Will consider libbsd as a future enhancement.