appneta / tcpreplay

Pcap editing and replay tools for *NIX and Windows - Users please download source from
http://tcpreplay.appneta.com/wiki/installation.html#downloads
1.17k stars 268 forks source link

[Bug] tcprewrite --skipbroadcast option not working #677

Closed fklassen closed 2 years ago

fklassen commented 3 years ago

Describe the bug It appears that this flag is ignored. I tested all the way back to version 3.4.4 and it wasn't working there either

To Reproduce Flag fails on L2 and L3. This tests L2.

  1. Run the following on a PCAP file that contains an ARP broadcast
    tcprewrite -b -s 55 -i arp.pcap \  
    --enet-dmac=00:12:13:14:15:16,00:22:33:44:55:66 \
    --enet-smac=00:22:33:44:55:66,00:12:13:14:15:16 \
    -o arp-out.pcap \
    -v -A"-ve"
  2. Inspect resultant file

Expected behavior Broadcast MAC address ff:ff:ff:ff:ff:ff should not be altered

Actual results MAC address modified

System (please complete the following information):

Additional context

fklassen commented 2 years ago

Fixed in PR #678