Closed yasskin closed 2 years ago
Description of changes:
[Add description back to BellIcon] Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2944-Icons-Replace-omitProps/?path=/docs/icons-icons-bellicon--primary
[DangerLightIcon Remove omitProps Update Story to SB6] [Update DangerLightIcon snapshot] Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2944-Icons-Replace-omitProps/?path=/docs/deprecated-dangerlighticon--basic
[GripperHorizontalIcon Add Story, Fix PropTypes] Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2944-Icons-Replace-omitProps/?path=/docs/icons-icons-gripperhorizontalicon--primary
[GripperVerticalIcon add Story, Remove omitProps] Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2944-Icons-Replace-omitProps/?path=/docs/icons-icons-gripperverticalicon--primary
[InfoLightIcon Remove OmitProps, Update Story] Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2944-Icons-Replace-omitProps/?path=/docs/deprecated-infolighticon--basic
[WarningLightIcon Remove omitProps, Update Story] Link(s) to Storybook on docspot:
https://docspot.adnxs.net/projects/lucid/CXP-2944-Icons-Replace-omitProps/?path=/docs/deprecated-warninglighticon--basic
[Add test for initialState to generic Icon test] [Add config to skip initial state test for Icon] [Add new Icon stories to load-icons and index files]
Manually tested across supported browsers
[ ] Two core team engineer approvals
[ ] One core team UX approval (as necessary)
[x] Unit tests written (common at minimum)
common
[x] PR has one of the semver- labels
semver-
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
PR Checklist
Description of changes:
[Add description back to BellIcon] Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2944-Icons-Replace-omitProps/?path=/docs/icons-icons-bellicon--primary
[DangerLightIcon Remove omitProps Update Story to SB6] [Update DangerLightIcon snapshot] Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2944-Icons-Replace-omitProps/?path=/docs/deprecated-dangerlighticon--basic
[GripperHorizontalIcon Add Story, Fix PropTypes] Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2944-Icons-Replace-omitProps/?path=/docs/icons-icons-gripperhorizontalicon--primary
[GripperVerticalIcon add Story, Remove omitProps] Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2944-Icons-Replace-omitProps/?path=/docs/icons-icons-gripperverticalicon--primary
[InfoLightIcon Remove OmitProps, Update Story] Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2944-Icons-Replace-omitProps/?path=/docs/deprecated-infolighticon--basic
[WarningLightIcon Remove omitProps, Update Story] Link(s) to Storybook on docspot:
https://docspot.adnxs.net/projects/lucid/CXP-2944-Icons-Replace-omitProps/?path=/docs/deprecated-warninglighticon--basic
[Add test for initialState to generic Icon test] [Add config to skip initial state test for Icon] [Add new Icon stories to load-icons and index files]
Manually tested across supported browsers
[ ] Two core team engineer approvals
[ ] One core team UX approval (as necessary)
[x] Unit tests written (
common
at minimum)[x] PR has one of the
semver-
labels