Cxp 2571 loading message replace omit props - Githubissues

appnexus / lucid

A UI component library from Xandr.

https://appnexus.github.io/lucid

Other

201 stars 80 forks source link

Cxp 2571 loading message replace omit props #1358

Closed yasskin closed 2 years ago

yasskin commented 2 years ago

PR Checklist

Description of changes: For LoadingMessage:

replace omitProps with an explicit list of props.
add Storybook story for LoadingMessage
add unit test to ensure the correct props are being omitted and passed through to the underlying root element

Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2571-LoadingMessage-replace-omitProps/?path=/docs/loading-message-loadingmessage--basic

Manually tested across supported browsers
- [x] Chrome
- [ ] Firefox
- [ ] Safari
[ ] Two core team engineer approvals
[ ] One core team UX approval (as necessary)
[x] Unit tests written (common at minimum)
[x] PR has one of the semver- labels

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.