Closed yasskin closed 2 years ago
Description of changes for StickySection: Replace omitProps by propTypes with an explicit list Update Storybook story Add unit test for omitted props.
StickySection
Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2584-StickySection-replace-omitProps/?path=/docs/helpers-stickysection--with-lower-bound
Manually tested across supported browsers
[ ] Two cxp team engineer approvals
[ ] One product design approval (as necessary)
[ ] Unit tests written (common at minimum)
common
[x] PR has one of the semver- labels
semver-
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
PR Checklist
Description of changes for
StickySection
: Replace omitProps by propTypes with an explicit list Update Storybook story Add unit test for omitted props.Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2584-StickySection-replace-omitProps/?path=/docs/helpers-stickysection--with-lower-bound
Manually tested across supported browsers
[ ] Two cxp team engineer approvals
[ ] One product design approval (as necessary)
[ ] Unit tests written (
common
at minimum)[x] PR has one of the
semver-
labels