Cxp 2593 vertical tabs & table fix omit props - Githubissues

appnexus / lucid

A UI component library from Xandr.

https://appnexus.github.io/lucid

Other

201 stars 83 forks source link

Cxp 2593 vertical tabs & table fix omit props #1369

Closed yasskin closed 2 years ago

yasskin commented 2 years ago

PR Checklist

Description of changes for VerticalTabs and Table components:

Add unit tests for prop types
Update Stories with args and Story TS definition
Replace omitProps with explicit list of props

Link(s) to Storybook on docspot: https://docspot.adnxs.net/projects/lucid/CXP-2593-VerticalTabs-fix-omitProps/?path=/docs/navigation-verticaltabs--basic

Screen Shot 2022-04-20 at 12 32 46 PM

https://docspot.adnxs.net/projects/lucid/CXP-2593-VerticalTabs-fix-omitProps/?path=/docs/table-table--basic Screen Shot 2022-04-21 at 10 00 54 AM

Manually tested across supported browsers
- [x] Chrome
- [ ] Firefox
- [ ] Safari
[ ] Two cxp team engineer approvals
[ ] One product design approval (as necessary)
[x] Unit tests written (common at minimum)
[x] PR has one of the semver- labels

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.