search

appnexus / pyrobuf

A Cython alternative to Google's Python Protobuf library
Other
554 stars 76 forks source link

Comment parsing #137

Closed ChristianToepfer closed 1 year ago

ChristianToepfer commented 5 years ago

Add comment parsing #136 for message and enum definition. I only use the doxygen comments ( /*.../,///) and skip normal developer comments (/.../,//) to filter IDE-Help. IDE-Help with docstring for python classes and getter function. To be able to show any help for enum definition in python, I had to define the enums as a class. Help to single Enum-Item is still open.

tburmeister commented 5 years ago

This is great! Going to request some changes, but overall I think this looks good.

tburmeister commented 5 years ago

This branch is failing tests/test_imported_enums.py, tests/test_items.py, tests/test_merge_from.py, and tests/test_parser/test_oneof.py for me. Should probably add a unit test for proper comment parsing as well.

ChristianToepfer commented 5 years ago

Tests are simply something fine. Two of them shown me a bug. I had to adapt a few others for class enum. Comment parsing tests coming soon.

ChristianToepfer commented 1 year ago

remove comment parsing/providing with pyrobuf. Worked with pyi-files (pyrogen-stubs) much better