search

appnexus / sicksync

Don’t accept the available as the preferable. Go the extra mile with extra speed.
Apache License 2.0
68 stars 11 forks source link

Fixes #9 by adding in plain old `indexOf` matching for folder excludes. #10

Closed jondlm closed 9 years ago

jondlm commented 9 years ago

This should revert the old behavior of being able to add .git to your includes config and have it work as expected. Includes tests.

Note: there might be a better way to do file matching ala git style, but this was the easy button.

jondlm commented 9 years ago

Fixes #9

joelgriffith commented 9 years ago

I should have called this out in the update since I didn't mention updating configs :cry:

The latest code now accepts the fancy-pants glob/**/*.js patterns, but isn't necessarily backwards compatible with the old indexOf hackery.

Could you possibly update your config file and see if .git/** works? You can open it up easily with sicksync -c if you're on v1.1x. I'd like to keep what's there as it's more flexible in it's ability to white/black-list.

jondlm commented 9 years ago

Yep, that worked. Sorry for the false alarm.