search

appnexus / sicksync

Don’t accept the available as the preferable. Go the extra mile with extra speed.
Apache License 2.0
68 stars 11 forks source link

Windows support? #42

Closed laggingreflex closed 8 years ago

laggingreflex commented 8 years ago

Windows support would be awesome. ssh isn't natively available on Windows, it's usually available through Git Bash or cygwin or babun. There's also https://github.com/mscdex/ssh2

Thoughts?

laggingreflex commented 8 years ago

I see that this is using rsync, and it does seem to support windows, although some additional config may be required:

https://github.com/mattijs/node-rsync/pull/34#issuecomment-232057705 https://github.com/mattijs/node-rsync/issues/29#issuecomment-152001865

Though I haven't looked at any of it close enough, I haven't used either of these libraries before.

laggingreflex commented 8 years ago

Actually nevermind. I just need to put the bin directory (that contains git.exe and rsync.exe) in the path. Git bash doesn't come with rsync.exe so it has to be cygwin or babun

SET PATH=%PATH%;%UserProfile%\.babun\cygwin\bin
laggingreflex commented 8 years ago

Sorry for prematurely closing but there were still some issues. I'll be submitting another PR fixing/highliting them shortly...