Fix file watcher excludes issue

appnexus / sicksync

Don’t accept the available as the preferable. Go the extra mile with extra speed.

Apache License 2.0

68 stars 11 forks source link

Fix file watcher excludes issue #48

Closed laggingreflex closed 7 years ago

laggingreflex commented 7 years ago

Fix file watcher excludes issue (#47)

Prior to this the File watcher (chokidar) wasn't actually ignoring the excludes. It is required to have cwd option passed in for it to work. (small discussion on the issue here)

Also use anymatch instead of minimatch. It better handles matching both globbed and non-globbed paths.

With these changes we can now simply have exclude patterns like .git, or node_modules (instead of .git/** and .git/**/* or **/.git/**)

joelgriffith commented 7 years ago

Sweet, sorry again for the delay in merging these, looks good!