search

appnexus / sicksync

Don’t accept the available as the preferable. Go the extra mile with extra speed.
Apache License 2.0
68 stars 11 forks source link

Adding a dir that's excluded fires adddir event #52

Closed laggingreflex closed 7 years ago

laggingreflex commented 7 years ago

If you have node_modules excluded but the dir node_modules hasn't actually been created yet and you've started the sync and then do npm i which creates the node_modules dir, it fires the adddir event which causes the Big Rsync to be fired again. But it doesn't do anything much which is good and expected, so this probably isn't of immediate concern but still leaving this here so it might be addressed.

joelgriffith commented 7 years ago

Fixed in 3.0.0 thanks to your work!