appodeal / Appodeal-Flutter-Plugin

Official Flutter Plugin that adds Appodeal SDK support to your Flutter application.
https://pub.dev/packages/stack_appodeal_flutter
Apache License 2.0
18 stars 3 forks source link

after upd to flutter 3 #16

Closed BlackJet1 closed 2 years ago

BlackJet1 commented 2 years ago

Steps to Reproduce

e: E:\Flutter.pub-cache\hosted\pub.dartlang.org\stack_appodeal_flutter-1.2.0\android\src\main\kotlin\com\appodeal\appodeal_flutter\AppodealAdViewFactory.kt: (9, 10): Class 'AppodealAdViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Cont ext?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory e: E:\Flutter.pub-cache\hosted\pub.dartlang.org\stack_appodeal_flutter-1.2.0\android\src\main\kotlin\com\appodeal\appodeal_flutter\AppodealAdViewFactory.kt: (12, 5): 'create' overrides nothing

FAILURE: Build failed with an exception.

imariman commented 2 years ago

Is this repo still active? We can't run our Android app because of this very simple issue since last week.

mrgzi commented 2 years ago

https://docs.flutter.dev/development/platform-integration/platform-views

I talked about this with Appodeal support team. They said it can take a few weeks to update the package for flutter 3.

da2gl commented 2 years ago

Hi @BlackJet1, @imariman, @mgazisalik . We have started updating the plugin for 3.0 compatibility. Have a nice day.

Defuera commented 2 years ago

Fix is here https://github.com/appodeal/Appodeal-Flutter-Plugin/pull/18

da2gl commented 2 years ago

@Defuera Thanks for your PR. We created new release from your template fix.

@BlackJet1, @imariman, @mgazisalik new version already on pub.dev

mrgzi commented 2 years ago

@Defuera , @da2gl thank you.

wandermonk1 commented 2 years ago

I updated the new package still my app is crashing. Working fine if I commented out the follwowing line in App level build.graddle

dependencies { implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version" // implementation 'com.appodeal.ads:sdk:2.11.0.+' }

Please help me

da2gl commented 2 years ago

@wandermonk1 Hello! Please attach log error.