appodeal / appodeal-cordova-plugin

Appodeal Cordova Plugin
https://www.appodeal.com
19 stars 33 forks source link

error when compiling ? #7

Open matrixreal opened 7 years ago

matrixreal commented 7 years ago

Hi, since cordova ios 4.X still not stable i'm using cordova ios 3.9.2 and xcode 7 i'm facing errors when compiling check the image attached can you please create a new git repo for ios 3.9.2 i can't use ios 4.X.X because of its instanstability and the plugin i use is only supported on io 3.2.1 thanks appodealerror urgent

NazarKozak commented 7 years ago

@matrixreal Hi! Sorry for delay. I will try to rework callbacks with 3.x compatibility. Will update you till tomorrow. Is there any other problems except callbacks (webViewEngine not found)?

matrixreal commented 7 years ago

@NazarKozak no it's okay only callbacks problems thank you

matrixreal commented 7 years ago

or you can just create new appodealplugin.m file for ios 3.9.2 and you put it in the same folder with for example appodealplugin-ios3.m and we just need to remove / rename files as we use it

NazarKozak commented 7 years ago

@matrixreal i've made some changes and tested with Cordova ios@^3.9.2, it should work now.

NazarKozak commented 7 years ago

@matrixreal is it working for you?

matrixreal commented 7 years ago

@NazarKozak yes it's works but i did notice that now it's times more time to load rewarded video than before

matrixreal commented 7 years ago

@NazarKozak also ... when we finish viewing the rewarded video we got white screen this not happen before (appodeal 1.3.1)

NazarKozak commented 7 years ago

@matrixreal what version of iOS SDK was in that you have used before? I've tested rewarded video, works fine for me. Can you give me some details (device and ios ver, xcode ver). Also maybe you can send me log?

NazarKozak commented 7 years ago

@matrixreal do you still have problems with plugin?

KrylovAlexey commented 7 years ago

when we finish viewing the rewarded video we got white screen. Is it normal?

matrixreal commented 7 years ago

@NazarKozak @KrylovAlexey you see ... we have the same problem .... white screen after the rewarded video

vintage commented 7 years ago

Same issue here on iOS. Here's the output of the ionic info:

Your system information:

Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.5
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.0.0
ios-deploy version: 1.9.0
ios-sim version: 5.0.13
OS: macOS Sierra
Node Version: v7.4.0
Xcode version: Xcode 8.2.1 Build version 8C1002

ionic plugin list

com.appodeal.plugin 2.1.0 "Appodeal Plugin"
cordova-plugin-console 1.0.5 "Console"
cordova-plugin-crosswalk-webview 2.2.0 "Crosswalk WebView Engine"
cordova-plugin-device 1.1.4 "Device"
cordova-plugin-device-motion 1.2.3 "Device Motion"
cordova-plugin-email 1.2.6 "EmailComposer"
cordova-plugin-inappbrowser 1.6.1 "InAppBrowser"
cordova-plugin-inapppurchase 1.0.0 "In App Purchase"
cordova-plugin-insomnia 4.2.0 "Insomnia (prevent screen sleep)"
cordova-plugin-nativeaudio 3.0.7 "Cordova Native Audio"
cordova-plugin-splashscreen 4.0.1 "Splashscreen"
cordova-plugin-statusbar 2.2.1 "StatusBar"
cordova-plugin-whitelist 1.3.1 "Whitelist"
cordova-sqlite-storage 2.0.1 "Cordova sqlite storage plugin"
ionic-plugin-keyboard 2.2.1 "Keyboard"
me.tonny.cordova.plugins.multidex 0.1.0 "Cordova Multi Dex"
meeeeeepo commented 7 years ago

@matrixreal @vintage hello, can you please give us additional information? What devices did you use for tests, what iOS version and what ad network was it? Or you are getting white screen always after finishing rewarded video?

vintage commented 7 years ago

@meeeeeepo Device: Iphone SE System: iOS 10.2 (14C92) Orientation: Landscape only Ad network: eg. AdColony, but same situation occurs when forcing test mode and test ad from Appodeal is presented. After closing the add white screen hits you.

meeeeeepo commented 7 years ago

@vintage @matrixreal @KrylovAlexey we found that white screen is a result of conflict with cordova-plugin-statusbar. When ad is closed cordova-plugin-statusbar is capturing wrong view and sets current webView frame (0,0,0,0). To solve this try removing cordova-plugin-statusbar from your project

vintage commented 7 years ago

@meeeeeepo Thanks a lot, after removing the cordova-plugin-statusbar everything works well now! The reward video is presented, all the events are published to the app, the flow works as is should :) It's a great experience to use library with such support.

meeeeeepo commented 7 years ago

@vintage you are welcome! If you will need that cordova-plugin-statusbar plugin then you can download it from here https://github.com/appodeal/cordova-plugin-statusbar, we've made some changes there so white screen shouldn't appear with that version of plugin

matrixreal commented 7 years ago

@NazarKozak @meeeeeepo thanks a lot will give it a try can you tell us where to download the biggest file on this plugin ?

NazarKozak commented 7 years ago

@matrixreal You don't need to download anything. Plugin already contains all the SDK's.

matrixreal commented 7 years ago

@NazarKozak Hi, thanks a lot everything works good i just have problem on my appodeal dashboard when i try to synchronise with admob and i get this error appodeal

NazarKozak commented 7 years ago

@matrixreal Can you forward this to our support team? They should be able to help you with this.

vintage commented 7 years ago

@matrixreal Try to disable the adblock :)

matrixreal commented 7 years ago

@vintage damnnnn man .... it works ... i was stuck on it since 3 days of try thank you man

@NazarKozak i have a top chart game wich is connected to the old appodeal plugin (1.1.4) do you think that if i update it with lastest version it will have impact on ecpm / revenue ? thank you

NazarKozak commented 7 years ago

@matrixreal it should improve revenue :)

matrixreal commented 7 years ago

@NazarKozak Hi, can you kindly test the plugin with cordova ios 3.9.2 ? it still crash and get white screen i don't use cordova ios 4.x cause it still bug with other plugins that i need to use (iap plugins, iframe plugin etc ...) thank you

matrixreal commented 7 years ago

@NazarKozak please can you do something ? the white screen is still happen after the rewarded video on cordova ios 3.9.2

matrixreal commented 7 years ago

@NazarKozak hi ... i did spent 6 hours to test and test on different devices ios9 and ios10 with different cordova ios version and i did got these conclusions :

1- Cordova ios 4.3.1 wich is good but has bad performance and lag (specially when we use banner) but it work good (banner , interstitial, rewarded video) no problem at all .... but since it's laggy and has bad performance and low fsp ... we are forced to use the wkwebview official plugin wich improve the performance .... when we get wkwebview installed , all work good but after the rewarded video we got black screen with the message "error local server" (note that to make the wkwebview plugin work we have to install the cordova-plugin-file and cordova-plugin-httpd plugins) see picture 1

2- with corova ios 3.9.2 all is perfect except sometimes we get white screen after the rewarded video (with and without your updated status bar plugin)

i hope that will help and hope the problem will be fixed soon img_2428

meeeeeepo commented 7 years ago

@matrixreal can you please give full list of plugins that you use with ios@3.9.2? i tested plugin with that ios version and didnt get white screen

matrixreal commented 7 years ago

@meeeeeepo com.appodeal.plugin 2.1.0 "Appodeal Plugin" com.rjfun.cordova.httpd 0.9.2 "CorHttpd" com.telerik.plugins.wkwebview 0.6.10 "WKWebView Polyfill" cordova-plugin-app-event 1.2.0 "Application Events" cordova-plugin-compat 1.1.0 "Compat" cordova-plugin-device 1.1.4 "Device" cordova-plugin-dialogs 1.3.1 "Notification" cordova-plugin-file 4.3.1 "File" cordova-plugin-game-center 0.4.2 "Game Center" cordova-plugin-inappbrowser 1.6.1 "InAppBrowser" cordova-plugin-payment-iap 2.0.52 "Cordova IAP plugin" cordova-plugin-share-reviewapp 1.0.25 "Cordova ReviewApp plugin" cordova-plugin-statusbar 2.2.2-dev "StatusBar" cordova-plugin-webserver 1.0.3 "CordovaWebServer" cordova-plugin-whitelist 1.3.1 "Whitelist" cordova-plugin-x-socialsharing 5.0.7 "SocialSharing" de.appplant.cordova.plugin.local-notification 0.8.4 "LocalNotification"

Please test it on real device .... simulator is working on both ios 4.x and 3.9.2

thanks

meeeeeepo commented 7 years ago

@matrixreal can you try removing cordova-plugin-statusbar to test if it is the reason of problem?

meeeeeepo commented 7 years ago

@matrixreal https://cloud.githubusercontent.com/assets/6823974/22251644/d97f0ec8-e24b-11e6-9ceb-bd21d29a8242.jpg about this problem. I guess you got that error with iPhone 4/4s; have you tested it with later devices?

matrixreal commented 7 years ago

@meeeeeepo yes i did the test on iphone 4s i don'y have other device

meeeeeepo commented 7 years ago

@matrixreal this problem could be caused by small RAM memory size on that device, it takes some RAM memory to show rewarded video (more RAM when rewarded video is playable ad) so your local server got killed because of that memory lack; i tested with iphone 5 and higher and didn't reproduce that issue (Got it only with iPhone 4). I also couldn't reproduce white screen issue with later devices with updated status-bar plugin, but now i will test white screen with iPhone 4 only, so i hope i could catch that and fix soon

matrixreal commented 7 years ago

@meeeeeepo it's okay thank you any way to solve that memory crash ? something like memory management ?

meeeeeepo commented 7 years ago

@matrixreal our sdk actually needs about 50-150 MB of free RAM so i didin't find a way to fix that, the only way to fix it for you is to use cordova ios@3.9.2, I will investigate the white screen issue tomorrow and i hope i will find something to fix that

meeeeeepo commented 7 years ago

@matrixreal well i tested rewarded video with real iPhone 4s, and i didn't get white screen. I received both playable ad and common rewarded video with no issues. I don't know why you are still affected by that bug

matrixreal commented 7 years ago

@meeeeeepo strange but it's okay .... (so your lastest tests was with cordova ios 3.9.2) right ? so i will finally use ios 3.9.2 since it's the most stable and has good performance

meeeeeepo commented 7 years ago

@matrixreal yeah, i was testing with ios@3.9.2

manuelpaulo commented 7 years ago

@meeeeeepo, care to detail what changes have you made on the cordova-plugin-statusbar?

I am having a problem with my app, which is webview based and the appodeal skd. I am getting white screens on some devices.

I think it might be related to creating two webview clients simultaneously, one for mine, and one for yours: android:name="com.cmcm.picks.webview.PicksBrowser" android:launchMode="singleTask" android:theme="@android:style/Theme.Black.NoTitleBar.Fullscreen" />

Tamplier commented 7 years ago

hi, @manuelpaulo In cordova-plugin-statusbar we made only iOS related changes. As I know, there were no any problems with statusbar on android. Can you provide some details? Which version of cordova do you use? Do you use cordova CLI or some service to build your application? How frequently are you getting white screens? Maybe you found that you are getting white screens only after specific ad or ad network. Is white screen appears after showing specific ad type? On which devices are you getting the problem? And can you share apk in which the problem is reproduced? Thanks

manuelpaulo commented 7 years ago

Hi Tamplier,

I already shared all that info you're requesting with appodeal support (Laura Suco Torres).

Just trying to find more info on how to solve this, or else I will have to leave appodeal, as one star ratings are pilling up and I can't afford losing my top rank.

Big problem is I am unable to reproduce the issue. It's clearly a white screen freeze, as that's what the very unsatisfying users are complaining about.

Could not isolate by hardware specs also, which is even stranger.

Webview conflict is my best guess, as it happens on other Android apps.

Thanks

manuelpaulo commented 7 years ago

Some ideas:

Should I use shouldOverrideUrlLoading on my webview? Maybe try setting setJavaScriptCanOpenWindowsAutomatically to TRUE?

Thanks.