appodeal / react-native-appodeal

Official React Native package that adds Appodeal SDK support to your react-native application.
https://appodeal.com
59 stars 37 forks source link

Placement ids aren't registered for Android #48

Closed zoftify closed 3 years ago

zoftify commented 3 years ago

Hi, thanks a lot for the plugin!

I noticed there is an issue related to the placements. I have the same code for android & ios and registered the same placements for iOS and Android. iOS works like a charm, but Android placements aren't recognized:

image

How can we fix that?

Cheers!

staskochkin commented 3 years ago

Hello @zoftify. I've checked that plugin is sent placement from JS to Android native SDK. I think that this issue is not related to plugin logic. Please contact our support team via intercom or email support@appodeal.com. It should be a more convenient way to solve it.

zoftify commented 3 years ago

@staskochkin what I can see from the logs that we're always sending default placement:

2020-08-21 23:54:36.655 8761-8761/XXX D/Appodeal: Banner [Show]: isDebug: false, isLoaded: false, isLoading: true, placement: 'default', inPopup: false
2020-08-21 23:54:36.661 8761-8761/XXX D/Appodeal: SDK-Public [Appodeal]: show. Banner, result: true
2020-08-21 23:54:36.842 8761-8761/XXX D/Appodeal: Banner [Loaded]: Applovin - eCPM: 0.00, precache: false, expTime: 0, id: N2lWR...
2020-08-21 23:54:36.842 8761-8761/XXX D/Appodeal: Banner [Cancel]: Appodealx - eCPM: 10000.00, precache: false, expTime: 1680, id: NGZNW...
2020-08-21 23:54:36.843 8761-8761/XXX D/Appodeal: Banner [Notify Loaded]: height: 50dp, isPrecache: false
2020-08-21 23:54:36.843 8761-8761/XXX D/Appodeal: Banner [Show]: isDebug: false, isLoaded: true, isLoading: false, placement: 'default', inPopup: false
2020-08-21 23:54:36.880 8761-8761/XXX D/Appodeal: Banner [Network Error]: Appodealx - AdError: No fill

Here is my component:

<AppodealBanner
          placement={'home_screen_bottom'}
          style={{
            width: '100%',
            alignContent: 'stretch',
          }}
          onAdLoaded={() => {
            // LayoutAnimation.configureNext(LayoutAnimation.Presets.easeInEaseOut)
            setAdLoaded(true)
          }}
          onAdFailedToLoad={() => {
            // LayoutAnimation.configureNext(LayoutAnimation.Presets.easeInEaseOut)
            // setAdLoaded(false)
          }}
          adSize={size}
        />

As I said, iOS is perfect, the issue is only for Android...

staskochkin commented 3 years ago

@zoftify Thanks for log and code snippet. Looks like we missed placement for the AppodealBanner component on the Android platform. We will fix it in the next release.

staskochkin commented 3 years ago

Fix has been released in 2.7.4