appodeal / react-native-appodeal

Official React Native package that adds Appodeal SDK support to your react-native application.
https://appodeal.com
59 stars 37 forks source link

Add smart banner view for iOS #58

Closed dylancom closed 3 years ago

dylancom commented 3 years ago

The custom banner view currently doesn't expose a prop to make use of smart banners.

EDIT: although this exposes usesSmartSizing, I'm still seeing FB banners with a fixed with of 320px. I'm also getting 320 width for Facebook banners when using:

Appodeal.setSmartBanners(true);
Appodeal.show(AppodealAdType.BANNER_TOP);

Does Appodeal support full width Facebook banners or just AdMob?

staskochkin commented 3 years ago

Hi @dylancom Appodeal Facebook adapter uses kFBAdSizeHeight50Banner for phones and kFBAdSizeHeight90Banner for tablets according to doc

dylancom commented 3 years ago

@staskochkin do you have any clue why it's not taking the full width? According to the docs height50 represents a banner with a fixed height and a flexible width. I have only seen AdMob banners take up the full width.

BANNER_HEIGHT_50 Represents a flexible banner ad size, where banner width depends on its container width, and banner height is fixed as 50dp.

https://developers.facebook.com/docs/reference/android/current/class/AdSize/

staskochkin commented 3 years ago

@dylancom I think the width of the banner depends on the layout of the particular creative. But we will try to check it on the native iOS SDK side.