search

appointer / swaggervel

Swagger for Laravel
70 stars 40 forks source link

Update zircote/swagger-php to 3 version #28

Closed denkurbatov closed 4 years ago

denkurbatov commented 4 years ago

Update zircote/swagger-php to version 3.0 that supports php 7.4

Now when using php 7.4 got error:

Trying to access array offset on value of type bool at /var/www/app/vendor/zircote/swagger-php/src/StaticAnalyser.php:278)

fgreinus commented 4 years ago

Hey, thanks for the PR! Did you test everything? Cause version 3.0 introduces a new spec and we should validate compatibility https://github.com/zircote/swagger-php/releases/tag/3.0.0.

denkurbatov commented 4 years ago

I'm delete my PR cause the same already exists - https://github.com/appointer/swaggervel/pull/17

@fgreinus If i will test everything (or almost everything) is it any chance that PR will be merged to master?

fgreinus commented 4 years ago

Sure! Thx!

Denys Kurbatov notifications@github.com schrieb am Sa., 28. Dez. 2019, 10:24:

I'm delete my PR cause the same already exists - #17 https://github.com/appointer/swaggervel/pull/17

@fgreinus https://github.com/fgreinus If i will test everything (or almost everything) is it any chance that PR will be merged to master?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/appointer/swaggervel/pull/28?email_source=notifications&email_token=AAJN6MPNR25VVVT7C7C4LDLQ24LOXA5CNFSM4J7KXWN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHYF73A#issuecomment-569401324, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJN6MP6MSN3JD4LHOMNV5LQ24LOXANCNFSM4J7KXWNQ .