appoptics / appoptics-api-go

The official Go client for the AppOptics metrics API
https://docs.appoptics.com/api/
Apache License 2.0
4 stars 7 forks source link

Use a different character to delimit tags/values when encoded as a string #10

Closed tillberg closed 4 years ago

tillberg commented 6 years ago

@akahn pointed out that colons are legal characters in tag keys and values, and so we should use something other than "::" to delimit them when encoding as a string (in https://github.com/librato/appoptics-go/blob/master/tags.go), as a tag key or value that includes "::" would not be decoded correctly.

trevrosen commented 6 years ago

Alter to use a null byte literal \x00 as the separator