Use private logrus instance to separate messages from hosting application

appoptics / appoptics-api-go

The official Go client for the AppOptics metrics API

https://docs.appoptics.com/api/

Apache License 2.0

4 stars 7 forks source link

Use private logrus instance to separate messages from hosting application #34

Open martinkunc opened 6 years ago

martinkunc commented 6 years ago

STR:

Have an application using appoptics-api-go client
Set the logrus.SetLevel(logrus.DebugLevel)

My application starts logging at Debug, but also AppOptics Api shows internal log messages, like

DEBU[2381] Uploading AppOptics measurements batchtime2018-03-19 11:24:15 +0100 CETnumMeasurements10globalTagsmap[hostname:brn-dev-mkun]

Wouldn't it be better to use private logger instance to separate appoptics logging completelly ? Like:

var log = logrus.New()

What do you think ?

trevrosen commented 5 years ago

Ok 9 months later I finally get back to you. Yes this is a good idea, and we'll end up implementing it for 1.0.0 now that we have full feature coverage of the API.