Upgrade to be compatible with Terraform 0.12.x syntax

appoptics / terraform-provider-appoptics

Apache License 2.0

4 stars 2 forks source link

Upgrade to be compatible with Terraform 0.12.x syntax #7

Closed solarchad closed 3 years ago

solarchad commented 5 years ago

See: https://www.terraform.io/docs/extend/terraform-0.12-compatibility.html
Before we do this, make sure there's a version released for <= 0.11.x TF compatible versions

sandnabba commented 4 years ago

Would it be possible for the provider to support both versions?

I would be more then happy to help trying out TF 0.12 support as well. We are currently setting up alerts for the TM environment using this provider. And since this is come completely new states that don't depend on anything else, we could use TF 0.12 also.

solarchad commented 4 years ago

Unfortunately I don't believe the provider can be compatible with <= 0.11.x and >= 0.12.x of Terraform. I imagine that we could make a release of this provider that is fully working with 0.11.x (which was the initial target) and then cut a new release of the provider once we have something working with 0.12.x. Here's a doc about provider compatibility for 0.12.x with more details.

sandnabba commented 4 years ago

Well, that page actually says: "As a result, most of the work to support Terraform 0.12 comes just from upgrading to the latest Terraform SDK, which features support for both the old and new provider protocols." :smiley:

But I don't have any experience developing Terraform at all, so I really don't know. :)

Anyways, seems like TF is dropping support for 0.11 in the official providers: https://www.hashicorp.com/blog/deprecating-terraform-0-11-support-in-terraform-providers/ So not sure if a 0.11 version is needed. But I don't know what the TF 0.12 adoption looks like in the "real world" either.

Anyways, all I wanted to say is that I personally would like to try out TF 0.12 and I can help trying the provider as well. :wink:

solarchad commented 4 years ago

I stand corrected :) I think for us though, we have so much code on 0.11.x that it made sense at the time to make this target that. This may change quickly though as I know there is work to upgrade to 0.12.x. Thanks for the offer to help test 0.12.x. If we can get some time to work on it, I'd like to bring you in to help test things.

n0rig commented 4 years ago

What's the status of this, guys?

solarchad commented 4 years ago

@n0rig and @sandnabba: there's a new beta release which should work with Terraform versions 0.12 and 0.13. Can you give it a shot and report back if it's not working for you?

sandnabba commented 3 years ago

@n0rig @solarchad Yeah, we've been using that for a few weeks without any issues (only to setup alerts). But so far, all good! :+1: :smiley: