search

appreciated / apexcharts-flow

ApexCharts.js wrapper for the Vaadin Platform
Apache License 2.0
77 stars 47 forks source link

Fix Typescript errors #156

Closed F43nd1r closed 1 year ago

F43nd1r commented 1 year ago

I took a stab at #155 and Vaadin 24 compatibility. This basically just adds more type definitions to the code.

TFyre commented 1 year ago

Would it be possible to apply only the typescript changes on the current v23 version (ie skipping the version updates)? Then when V24 is released we can bump & release?

F43nd1r commented 1 year ago

@TFyre I have stripped all non-vital changes from the PR.

TFyre commented 1 year ago

Happy to merge, can you please squash the commits first?

F43nd1r commented 1 year ago

Usually you should be able to squash & merge right on the PR, but sure.

TFyre commented 1 year ago

Merged 👍

TIL!!

sishbi commented 1 year ago

Hi, when will this appear in a release?
I get lots of errors when running Vaadin 23.3.4 and it looks like this PR fixes them!

sishbi commented 1 year ago

@TFyre @F43nd1r Can you help me ?