search

appreciated / vaadin-app-layout

<app-layout> integration for Vaadin 8.1+, 10+ and 14+
Apache License 2.0
83 stars 44 forks source link

Polymer custom-style.html 404 #259

Closed cedricaebi closed 5 years ago

cedricaebi commented 5 years ago

Describe the bug "GET http://localhost:8080/bower_components/polymer/lib/elements/custom-style.html net::ERR_ABORTED 404" which probably comes from a shared style of yours.

I get this error only with 3.0.0.beta1. With both Lumo and Material.

Additional Information (please complete the following information):

probert94 commented 5 years ago

I noticed the same bug when trying to switch to the 3.0.0.beta1. I tryed to locate the wrong import and found only app-layout-styles with a probably wrong import. There is one ../ too much. However, to my understanding, this file shouldn't be needed, since there are the 2 theme-specifc files for Lumo and Material, which seem to have the correct imports.

appreciated commented 5 years ago

Version 3.1.0.beta1

You mean 3.0.0.beta1 right?

This is not a too problematic issue. This should not cause any problem with the application itself. Will fix in beta2.

@Springrbua The file is need by the UI-Tests only (they won't work without it 😅[only god knows why]), I hope Vaadin will release some day an free UI testing utility so I won't need to write my own.

probert94 commented 5 years ago

I get this error only with 3.0.0.beta1. With both Lumo and Material. ... Version 3.1.0.beta1

I am pretty sure this was only a typo.

cedricaebi commented 5 years ago

Jup sorry my bad.. of course 3.0.0.beta1

phobiac commented 5 years ago

This is not a too problematic issue. This should not cause any problem with the application itself. Will fix in beta2.

I'm not sure what your timeline is for 3.0.0.beta2, but this is causing an application breaking bug on my end. I've had to bump back down to 2.1.0.beta1 to not experience it as 2.1.0 is not compatible with Vaadin 13+.

I have a login page (using the vaadin-login-flow addon) that after authentication is supposed to send users to the default route. When I build with 3.0.0.beta1, after login the app tries to route to this custom-style.html page for some reason.

Could not navigate to 'bower_components/polymer/lib/elements/custom-style.html'
Reason: Couldn't find route for 'bower_components/polymer/lib/elements/custom-style.html'

I'm willing to share more about my setup if that would help solve this.

probert94 commented 5 years ago

@appreciated I noticed, that in our application there is no space between the title in the app-bar and the left border since version 3.0.0.beta1 and I guess, it has to do with this bug. Also, I am not sure if this bug is really related to the app-layout-styles, since they should never be loaded on the client and therefore the (wrong) import of custom-styles should not be triggered. So either this bug is related to some other file or the app-layout-styles is falsely loaded on the client.

appreciated commented 5 years ago

I'm willing to share more about my setup if that would help solve this.

No need this issue can be fixed very easily.

after login the app tries to route to this custom-style.html page for some reason.

This sounds really wierd.

appreciated commented 5 years ago

I noticed, that in our application there is no space between the title in the app-bar and the left border since version 3.0.0.beta1 and I guess, it has to do with this bug.

@Springrbua This is probably related to introduction of #190. I needed to replace the HorizontalLayout with FlexLayout to support changing the flex-direction please open another issue for this. FlexLayout does not have a setSpacing() method.

appreciated commented 5 years ago

@phobiac checkout 3.0.0.beta2

phobiac commented 5 years ago

@appreciated That fixed it for me! Thank you.