search

apprenda / kubernetes

Container Cluster Manager from Google
http://kubernetes.io
Apache License 2.0
3 stars 0 forks source link

Further work on the kubelet support for Windows #2

Closed alexbrand closed 8 years ago

alexbrand commented 8 years ago

One of the things I was interested in exploring was the ability to have a single docker manager.

Having a Windows docker manager that re-implemented large methods of the linux docker manager would most likely create a challenge in terms of maintainability.

Looking through @csrwng's changes, I noticed that the majority of the issues were around Windows not supporting the infrastructure container. In order to solve this, I added a new flag to the docker manager. This flag is true on Linux, and false on Windows, and is inspected when dealing with the infrastructure container.

I also reverted some of the commented out code to reduce the scope of the PR and to maintain functionality on the Linux kubeletl.

csrwng commented 8 years ago

Just one comment, other than that LGTM. I like the single DockerManager 👍