search

approach0 / search-engine

A math-aware search engine.
http://approach0.xyz
MIT License
346 stars 50 forks source link

Filtering results by source #29

Closed TheSil closed 3 years ago

TheSil commented 3 years ago

I thought I would create an issue for this. Sometimes it would be nice to filter which sources I want to display (some other MSE users expressed this request).

w32zhong commented 3 years ago

I will keep this in my TODO list.

TheSil commented 3 years ago

Maybe also worth considering to add the target site icon somewhere next to the link even in unfiltered version, just to aid visually the user so that he does not need to parse the url to see from where it is.

Like some of these (mad paintbrush skills): variant1 variant2 variant3

(personally i like the last one as it seems the most minimal, some additional space could be also obtained by hiding the "http://" and "https://" part of the link)

w32zhong commented 3 years ago

@TheSil I also prefer the last one. I have made those changes in the UI repo (commit 1995e8a). With that, I am about to deploy it online, you can check it out in a few minutes...

I remember last time you have brought up this idea but I thought that would hurt the general purpose if people use a0 engine to host other data sources, but currently we only get 2 data sources and as long as we both feel like it, why not?

TheSil commented 3 years ago

Thanks for the update, it looks very good!

As for the genericity, I suppose this is a generic user requirement, just the logos would be perhaps different (or absent) for specific data sources. However how to do this genericity in the code, that I am not sure (i am not a web developer unfortunately), but seems like the logos would have to be part of some specific data source metadata that they provide to the framework? Idk.

w32zhong commented 3 years ago

Right, if they need icons to be displayed for another data source, they can modify this repo, but I have made it in vue-if-else directives so if they do not specify, it won't hold the place. I think it is good, it is just an option.

w32zhong commented 3 years ago

Solved in the latest private code.