search

approachcircle / Pong

a pong game written in LibGDX
GNU General Public License v3.0
1 stars 1 forks source link

refactor unnecessary input processor removal #17

Closed approachcircle closed 4 months ago

approachcircle commented 4 months ago

this seems really dumb: https://github.com/approachcircle/Pong/blob/9a51eca9940ffaba7e6c937a197bdc5b87aff700/src/main/java/net/approachcircle/game/backend/Button.java#L61 considering we remove the input processor here anyway: https://github.com/approachcircle/Pong/blob/9a51eca9940ffaba7e6c937a197bdc5b87aff700/src/main/java/net/approachcircle/game/backend/Button.java#L51 and then finally readd it again here???: https://github.com/approachcircle/Pong/blob/9a51eca9940ffaba7e6c937a197bdc5b87aff700/src/main/java/net/approachcircle/game/backend/Button.java#L67

(this might have performance consequences considering it runs every frame)

approachcircle commented 4 months ago

buttons seem to work fine after removal, but will need to be monitored if further issues arise