Clear timeout, always callback and code cleanup

[Andries-Smit]

Thank you for this great and handy widget,

We got a contribution, I hope you take this in:

• Clear interval on destroy; the interval continued after the page was closed.
• Always callback on update, in some cases the when there are error or no context object the callback was not called.
• Always reset subscription; in case the context object is empty, we always net to remove the subscription.
• Use UI error message; removed the alert and use standard UI error.
• Removed superfluous code and comments - some code did not have any function and was removed.
• Code consistency; use braces and and quotes.
• Removed deployment and SVN folders; no need to keep them in the GitHub repo.

Cheers, Andries

[joelvdgraaf]

Hi Andries, Thanks for your contribution. Can you please explicate which problem you've solved with this new set of code? Because you've changed a large set of the original code. Thanks in advance! Regards Joël

[Andries-Smit]

There where 3 issues.

• Clear interval on destroy; the interval continues after the page has been closed, keeping this reference is a memory leak. And the code keep on running, which can cause other errors along the way.

• Always callback on update; in some cases, for example on an error or no context object the callback was not called, causing a white screen.

• Always reset subscription; in case the context object is empty, we always need to remove the subscription, to the previous object. When the update is performed, with no context is provided. This is relevant for the data view listen to list view or data grid. When no item is selected, there is no context.

The biggest change though, was removing the deployment and .svn folders. The commits are nicely split per improvement, so you can verify them more easily.

Please let me know if you need more information, or test coverage.