search

appropriate / docker-jetty

Formerly the location of the Docker official image for Jetty
https://registry.hub.docker.com/_/jetty/
46 stars 46 forks source link

jetty user home is not properly set #106

Closed surli closed 4 years ago

surli commented 5 years ago

Current jetty images leaves the default home for the jetty user (i.e. /home/jetty) which might lead to various errors when building a custom image from it.

The error is easy to reproduce : 

[urli@vivat ~]$ docker run -it jetty:latest /bin/bash
jetty@c48a79115c75:/var/lib/jetty$ cd
bash: cd: /home/jetty: No such file or directory
gregw commented 5 years ago

Happy to define the home directory.... just wondering if it should be $JETTY_HOME or $JETTY_BASE? I'm leaning towards $JETTY_BASE.

surli commented 5 years ago

IMO it would be less surprising for users to have $JETTY_HOME as the jetty user home directory.

gregw commented 5 years ago

I'm looking for other examples in unix. gdm home is /var/lib/gdm3 and not /usr/lib/gdm3/ where the code lives. $JETTY_HOME is equivalent to usr directory and $JETTY_BASE is the /var directory in which you expect to make modifications.

... yes they should have been named the other way around...

surli commented 5 years ago

ahah indeed :) so I guess a good compromise might be to indeed use JETTY_BASE as home dir, and to document it in https://docs.docker.com/samples/library/jetty/#environment

joakime commented 4 years ago

This issue has been moved to the new Official Eclipse Jetty Docker repository.

See https://github.com/eclipse/jetty.docker/issues/106