search

approvals / ApprovalTests.Java

ApprovalTest verification library for Java
Apache License 2.0
339 stars 74 forks source link

Switch arguments to diff-tool #26

Open roesslerj opened 8 years ago

roesslerj commented 8 years ago

Currently, the diff-tool is called with arguments: .received. .approved., causing the expected result to be on the right side of the merge/diff-tool. Default is that the expected result is to the left.

Could the order of the arguments be switched, so the approved result shows up on the left?

Great! Thanks!

isidore commented 8 years ago

No. Many of the diff tools will not let you move changes from right to left. Since the approved file is often created in the diff tool by moving the results you got to the approved side reversing the order is problematic.

Llewellyn Falco www.approvaltests.com

On Tue, Jun 28, 2016 at 2:46 PM, Jeremias Rößler notifications@github.com wrote:

Currently, the diff-tool is called with arguments: .received. .approved., causing the expected result to be on the right side of the merge/diff-tool. Default is that the expected result is to the left.

Could the order of the arguments be switched, so the approved result shows up on the left?

Great! Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/approvals/ApprovalTests.Java/issues/26, or mute the thread https://github.com/notifications/unsubscribe/AAAqehO3qQh1u8ddvVXc6VcaghYVZRNPks5qQWvrgaJpZM4JAaQR .

roesslerj commented 8 years ago

Thanks for the fast feedback!