search

approvals / ApprovalTests.cpp

Native ApprovalTests for C++ on Linux, Mac and Windows
https://approvaltestscpp.readthedocs.io/en/latest/
Apache License 2.0
316 stars 51 forks source link

Doctest 2.3.7 fix #108

Closed p-podsiadly closed 4 years ago

p-podsiadly commented 4 years ago

Description

In doctest 2.3.7, the type of SubcaseSignature::m_name was changed from const char* to doctest::String. As a result, ApprovalTests doesn't compile with this version.

The change was introduced in this commit.

claremacrae commented 4 years ago

@p-podsiadly Super - thanks for this. I've been meaning to set something up to test ApprovalTests.cpp with a range of different supported versions with our 3rd-party dependencies - this will prompt me to have a go.

In the mean time, I aim to test this in the next day or so....

claremacrae commented 4 years ago

This is great - thanks for splitting it in to two commits, so it was super-easy to test.