Closed claremacrae closed 4 years ago
In pairing with a user today, we found that some code in this library did not compile on Mac with -Wshadow-field-in-constructor enabled, as we have some constructor arguments whose names match the names of data members.
-Wshadow-field-in-constructor
See this for why this matters:
https://stackoverflow.com/questions/34895661/why-does-the-compiler-warn-about-shadowing-a-member-in-initalization-lists
Version: v.8.4.0
This is now fixed, by adding -Wshadow to clang and gcc builds, and fixing all the compilation failures in Travis, AppVeyor and GitHub builds.
-Wshadow
In pairing with a user today, we found that some code in this library did not compile on Mac with
-Wshadow-field-in-constructor
enabled, as we have some constructor arguments whose names match the names of data members.See this for why this matters:
https://stackoverflow.com/questions/34895661/why-does-the-compiler-warn-about-shadowing-a-member-in-initalization-lists