search

approvals / ApprovalTests.cpp

Native ApprovalTests for C++ on Linux, Mac and Windows
https://approvaltestscpp.readthedocs.io/en/latest/
Apache License 2.0
316 stars 51 forks source link

Catch2 integration does not always print the exception text #113

Closed claremacrae closed 4 years ago

claremacrae commented 4 years ago

Pairing with a user today, with a custom Catch2 main, we found repeatedly that when Approvals threw an exception, Catch2 just reported something like "Unexpected exception" - and didn't display the exception text.

This meant that we had to debug every Approvals test failure, which wasted a bunch of time.

I believe I have seen this previously, but have not been able to track down why it only happens in some uses of Catch2.

claremacrae commented 4 years ago

Version: v.8.4.0

claremacrae commented 4 years ago

This turned is believed to be a problem with the user's Catch setup on Mac, which failed to print the exception text from throwing of simple C++ exceptions - and nothing specific to Approval Tests.

The same code worked fine on their Linux and Windows machines.

So I'm going to close this, as it's not actionable for us, as far as I can see.