approvals / ApprovalTests.cpp

Native ApprovalTests for C++ on Linux, Mac and Windows
https://approvaltestscpp.readthedocs.io/en/latest/
Apache License 2.0
318 stars 51 forks source link

Fix GitHub Actions Windows CI builds' failure to find Boost #125

Closed claremacrae closed 4 years ago

claremacrae commented 4 years ago

This build ran fine (both are on the Options branch - there are no changes to our build configuration in between...)

So the change was something to do with the update of the Windows images from 20200319.1 to 20200416.1

claremacrae commented 4 years ago

This will likely have been the cause: Environment variable BOOST_ROOT will be deprecated in 2 month.

Others have found the problem: https://github.com/actions/virtual-environments/issues/749 - which says that there are fixes given in:

claremacrae commented 4 years ago

I've fixed this on the Options branch - having squashed together my various attempts at fixing it...

And I've cherry-picked the fix to the master branch.

Closing issue.