approvals / ApprovalTests.cpp

Native ApprovalTests for C++ on Linux, Mac and Windows
https://approvaltestscpp.readthedocs.io/en/latest/
Apache License 2.0
317 stars 51 forks source link

Make verifyExceptionMessage() support scrubbers #143

Closed claremacrae closed 4 years ago

claremacrae commented 4 years ago

This would be trivial to implement. It could be useful if the exception text contains some changing data.

claremacrae commented 4 years ago

Hmmmm - maybe it already does - a test to confirm this would be useful.

claremacrae commented 4 years ago

If it does, then we would just need to remove the Doxygen comment that says that it does not support scrubbers...

claremacrae commented 4 years ago

This is invalid - I remembered wrongly, it's this one that does not support scrubbers:

        /// Note that this overload ignores any scrubber in options
        static void verify(const ApprovalWriter& writer,
                           const Options& options = Options())
        {
            FileApprover::verify(*getDefaultNamer(), writer, options.getReporter());
        }
        ///@}

Marking this as invalid and closing...